Move fast and break things.
Merge vulnerabilities.
Double the work.
Merge code without tests.
Anything, but don’t let code become stale.

    • Deifyed@lemmy.ml
      link
      fedilink
      English
      arrow-up
      1
      ·
      1 year ago

      Sorry about the confusion. It’s not sarcasm. I’m just sick and tired of people blocking my PR because of an argument about wether the function should be called X or Y or Z or D

      • jjjalljs@ttrpg.network
        link
        fedilink
        arrow-up
        1
        ·
        1 year ago

        Ah. Yeah those kind of nitpicks are annoying. We try to specify when comments are blocking or non blocking on reviews.

        But I definitely block a lot of reviews over no tests, bad tests, no error handling, failed linting. And the occasional “this doesn’t do what the ticket asked for”